feat: refactored as_ref_mut.rs to as_ref.rs and as_mut1.rs and add as_mut2.rs#1306
Closed
jtcours wants to merge 1 commit intorust-lang:mainfrom
Closed
feat: refactored as_ref_mut.rs to as_ref.rs and as_mut1.rs and add as_mut2.rs#1306jtcours wants to merge 1 commit intorust-lang:mainfrom
jtcours wants to merge 1 commit intorust-lang:mainfrom
Conversation
Contributor
|
I don't think that we should mix in other trait bounds. Users should focus on understanding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on exercises/conversions/as_ref_mut.rs, I thought it would be helpful to add an exercise to generalize the num_sq() function to work with any numeric type. The process of making that change gave me a better understanding of the syntax for trait bounds.
The new exercise led to creating "as_mut2.rs", which, in turn, led to refactoring "as_ref_mut.rs" into "as_ref.rs" and "as_mut1.rs".
Apologies in advance for bumping into Frosthage's change (#1113) which updates the hint for "as_ref_mut.rs". This change incorporates the change into "as_mut1.rs" instead.